drivers: mipi-dbi-spi: fix initialization of SPI CS #97366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
decsny
reviewed
Oct 10, 2025
jeremydick
force-pushed
the
mipi-dbi-spi-hw-cs
branch
from
b3f9427 to
7a68575
Compare
decsny
approved these changes
Oct 10, 2025
JarmouniA
approved these changes
Oct 10, 2025
|
Failing CI test is due to #97379 |
Set cs_is_gpio only if there is a GPIO CS, configure the CS as a native hardware CS if not This fixes incorrectly trying to use a GPIO CS when there isn't one Signed-off-by: Jeremy Dick <[email protected]>
jeremydick
force-pushed
the
mipi-dbi-spi-hw-cs
branch
from
7a68575 to
fe468c5
Compare
|
|
+1 to this PR Thanks. |
JarmouniA
approved these changes
Oct 13, 2025
JarmouniA
reviewed
Oct 15, 2025
| .delay = (delay_), \ | ||
| .cs_is_gpio = true, \ | ||
| COND_CODE_1(DT_SPI_DEV_HAS_CS_GPIOS(node_id), \ | ||
| (SPI_CS_CONTROL_INIT_GPIO(node_id, _delay)), \ |
There was a problem hiding this comment.
Suggested change
| (SPI_CS_CONTROL_INIT_GPIO(node_id, _delay)), \ | |
| (SPI_CS_CONTROL_INIT_GPIO(node_id, delay_)), \ |
Caught by #97581
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set cs_is_gpio only if there is a GPIO CS, configure the CS as a native hardware CS if not
This fixes incorrectly trying to use a GPIO CS when there isn't one